Vitor de Lima has posted comments on this change.
Change subject: Capabilities: List capabilities of the IBM POWER familiy
......................................................................
Patch Set 3:
(2 comments)
....................................................
File tests/capsTests.py
Line 30: def testCpuInfo(self):
Line 31: testPath = os.path.realpath(__file__)
Line 32: dirName = os.path.split(testPath)[0]
Line 33: path = os.path.join(dirName, "cpu_info.out")
Line 34: c = caps.CpuInfo(path, 'x86_64')
This is an interesting issue, the cpu_info.out file describes a x86_64 cpu,
while the host CPU that is running this test can be a PPC64. So, in order to
run this particular test properly on both archs, this must be explicitly set to
x86_64.
Line 35: self.assertEqual(set(c.flags()), set("""fpu vme de pse tsc msr
pae
Line 36: mce cx8 apic mtrr pge
mca
Line 37: cmov pat pse36 clflush
dts
Line 38: acpi mmx fxsr sse sse2
ss ht
....................................................
File vdsm/caps.py
Line 65: DEBIAN = 'Debian'
Line 66:
Line 67:
Line 68: class CpuInfo(object):
Line 69: def __init__(self, cpuinfo='/proc/cpuinfo', hostArch='x86_64'):
I will fix that. This was needed for a while to make the unit tests work, but I
forgot to change it.
Line 70: """Parse /proc/cpuinfo"""
Line 71: self._info = {}
Line 72: p = {}
Line 73: self.arch = hostArch
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
