Ayal Baron has posted comments on this change.
Change subject: Read pool metadata once in StoragePool.getInfo()
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/storage/sp.py
Line 1495: poolInfo = {
Line 1496: 'type': msdInfo['type'],
Line 1497: 'name': pmd[PMDK_POOL_DESCRIPTION],
Line 1498: 'domains': domainListEncoder(pmd[PMDK_DOMAINS]),
Line 1499: 'master_uuid': self.masterDomain.sdUUID,
nit: why change this from msdUUID? (e.g. msdUUID could be a property and in
any event is shorter).
Anyway, function should be consistent.
Line 1500: 'master_ver': pmd[PMDK_MASTER_VER],
Line 1501: 'lver': pmd[PMDK_LVER],
Line 1502: 'spm_id': pmd[PMDK_SPM_ID],
Line 1503: 'pool_status': 'uninitialized',
--
To view, visit http://gerrit.ovirt.org/14672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
