Dan Kenigsberg has posted comments on this change.
Change subject: tests: skip mkimageTests when mkisofs and mkfs.msdos don't exist
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
....................................................
Commit Message
Line 4: Commit: jarod.w <work.iec23...@gmail.com>
Line 5: CommitDate: 2013-09-09 14:07:00 +0800
Line 6:
Line 7: tests: skip mkimageTests when mkisofs and mkfs.msdos don't exist
Line 8:
Could you explain how these executables were missing? They should have been
pulled by the srpm's BuildRequires.
Line 9: Change-Id: I192707f466203786cd0864c8ca7c9e5070867523
....................................................
File tests/mkimageTests.py
Line 137: def _check_path(self, cmdpath):
Line 138: """
Line 139: Check whether execute file exists
Line 140: """
Line 141: try:
Please relate to Ayal's comment on former patchset
Line 142: if cmdpath.cmd is None:
Line 143: raise SkipTest("cannot execute %s" % cmdpath.name)
Line 144: except:
Line 145: raise SkipTest("cannot execute %s" % cmdpath.name)
--
To view, visit http://gerrit.ovirt.org/18984
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I192707f466203786cd0864c8ca7c9e5070867523
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23...@gmail.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
