Dan Kenigsberg has posted comments on this change. Change subject: vdsClient: Fix str/unicode concatenation issue. ......................................................................
Patch Set 2: Code-Review-1 (1 comment) .................................................... Commit Message Line 36: not in range(128) Line 37: Line 38: This patch is removing the str() conversion for infos['vmlist'][entry]. The result Line 39: is 'messages' variable as type unicode when infos['vmlist'][entry] is unicode. Line 40: Also, to avoid stdout redir encode error, the messages print is encoded as UTF-8. Could you explain this last point? What if the controlling terminal has a non utf8 enconding? Line 41: Line 42: Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b -- To view, visit http://gerrit.ovirt.org/19032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
