Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
......................................................................
Patch Set 9:
(2 comments)
....................................................
File init/daemonAdapter
Line 98: except Exception as e:
Line 99: if self._args and self._args.syslog:
Line 100: syslog.syslog("Error in daemonAdapater: %s" % e)
Line 101: else:
Line 102: sys.stderr.write("Error in daemonAdapater: %s" % e)
why not have log method?
Line 103: sys.exit(1)
Line 104:
Line 105:
Line 106: if __name__ == '__main__':
Line 104:
Line 105:
Line 106: if __name__ == '__main__':
Line 107: d = DaemonAdapter()
Line 108: sys.exit(d.execute())
double exit? here and at except?
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
