Dan Kenigsberg has submitted this change and it was merged. Change subject: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists ......................................................................
Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists Added functional tests for both functions as well. We can now parse rules that contain '[detached]' - If you add rules for devices that don't exist (Or add rules for devices that do exist and then delete the device) then 'ip rule' outputs the rule with '[detached]'. We couldn't parse such rules. This is important because when cleaning up rules that the test added we first get rid of the dummy nic and only then get rid of rules. Change-Id: Iaf7c28e85f53f51879750308f3a9f93fc635cf33 Signed-off-by: Assaf Muller <[email protected]> Reviewed-on: http://gerrit.ovirt.org/18040 Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/ipwrapper.py M tests/functional/networkTests.py M tests/functional/utils.py M tests/ipwrapperTests.py 4 files changed, 127 insertions(+), 12 deletions(-) Approvals: Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf7c28e85f53f51879750308f3a9f93fc635cf33 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
