Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
......................................................................
Patch Set 14:
(1 comment)
....................................................
File init/daemonAdapter
Line 57: help='Add options to be passed to target')
Line 58: self._args = parser.parse_args(sys.argv[1:])
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
I guess not parsing that currently will raise an exception, so that's not
necessary here, but we might need to scope the parse part in try except
Line 62: for m in msg.splitlines():
Line 63: syslog.syslog(m)
Line 64: else:
Line 65: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
