Assaf Muller has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network ......................................................................
Patch Set 4: (1 comment) .................................................... File vdsm/netmodels.py Line 89: Line 90: super(Nic, self).__init__(name, configurator, ipconfig, Line 91: mtu=mtu) Line 92: Line 93: def configure(self, **opts): Just a quick note. If A = isVlan and B = linkUp, then: Base patch was: (not A or not B) -> configure patch 1: not (A and not B) -> configure patch 4: (A and B) -> don't configure The base patch and patch 4 are logically equivalent while patch 1 is not equivalent to either. This is ignoring predicates C & D for this if statement, and any changes in the following if statement. Just bringing this up to make sure that the final outcome is what is intended. Line 94: # in a limited condition, we should not touch the nic config Line 95: if (self.vlan and Line 96: netinfo.operstate(self.name) == netinfo.OPERSTATE_UP and Line 97: netinfo.NetInfo().ifaceUsers(self.name) and -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
