Antoni Segura Puimedon has posted comments on this change.
Change subject: net tests: more combinations mtu combinations
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Only minor orthography question.
....................................................
File tests/functional/networkTests.py
Line 1124:
dict(remove=True)},
Line 1125: {})
Line 1126: self.assertEquals(status, SUCCESS, msg)
Line 1127:
Line 1128: def _createVlanedNetOverNicAndCheck(self, netNum, bridged,
**networkOpts):
Shouldn't it be vlanned instead of vlaned?
Line 1129: netName = NETWORK_NAME + str(netNum)
Line 1130: networks = {netName: dict(bridged=bridged,
Line 1131: vlan=str(int(VLAN_ID) + netNum),
Line 1132: **networkOpts)}
--
To view, visit http://gerrit.ovirt.org/19230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
