Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing automatic restart of services in libvirt-reconfigure ......................................................................
Removing automatic restart of services in libvirt-reconfigure libvirt-reconfigure also restarted libvirtd as post reconfigure operation. The restart is required but there is no reason and its not expected to perform it automatically as part of the reconfigure operation. Restart also required to supervdsmd service (as described in the Bug-Url). Instead of restarting both, this patch prints message to user to preform the restart manually. To make it easier and centralized the patch also adds libvirt-configure-services-restart command that restart related services after reconfigure. For backward compatibility with systemd, this also update systemd-vdsmd script to restart libvirtd and supervdsmd services in previous versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999853 Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/18780 Reviewed-by: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M init/systemd/systemd-vdsmd.in M init/sysvinit/vdsmd.init.in M lib/vdsm/tool/libvirt_configure.py M lib/vdsm/tool/libvirt_configure.sh.in 4 files changed, 28 insertions(+), 8 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches