Michal Skrivanek has posted comments on this change. Change subject: cleanup of vm.py ......................................................................
Patch Set 13: -Code-Review (2 comments) +1 on a break up .................................................... File vdsm/vm.py Line 1964 Line 1965 Line 1966 Line 1967 Line 1968 I'm sure. It was introduced after the new devices framework was already in place so it's useless Line 190: Line 191: def _setupRemoteMachineParams(self): Line 192: self._machineParams.update(self._vm.status()) Line 193: # patch VM config for targets < 3.1 Line 194: self._patchConfigForLegacy() IIRC we checked and it was only in vdsm 2.3. Line 195: self._machineParams['elapsedTimeOffset'] = \ Line 196: time.time() - self._vm._startTime Line 197: vmStats = self._vm.getStats() Line 198: if 'username' in vmStats: -- To view, visit http://gerrit.ovirt.org/18047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2712148b670c9f85beaea40a0b2e870d829b2b4b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
