Ayal Baron has posted comments on this change. Change subject: hsm: when creating fake template get template params before deleting ......................................................................
Patch Set 1: Code-Review-1 (1 comment) .................................................... File vdsm/storage/hsm.py Line 1536: if misc.parseBool(postZero): Line 1537: # postZero implies block domain. Backup domains are always NFS Line 1538: # hence no need to create fake template if postZero is true. Line 1539: self._spmSchedule(spUUID, "zeroImage_%s" % imgUUID, dom.zeroImage, Line 1540: sdUUID, imgUUID, volsByImg) what's creating the fake template in postZero case? Line 1541: else: Line 1542: if fakeTUUID: Line 1543: tParams = dom.produceVolume(imgUUID, fakeTUUID).\ Line 1544: getVolumeParams() -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches