Saggi Mizrahi has posted comments on this change.
Change subject: Raise specific exception when local path not exist
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/storageServer.py
Line 462: return os.path.join(self.localPathBase,
Line 463: self._path.replace("_",
"__").replace("/", "_"))
Line 464:
Line 465: def checkTarget(self):
Line 466: if not os.path.exists(self._path) or not
os.path.isdir(self._path):
If you look at change 6be8540d you'll see that Edu (wrongly) removed
validateDirAccess()
Please change it so we use validateDirAccess() and never add se exceptions to
storageServer.
Always, throw a custom exception and convert it in HSM
Line 467: raise se.StorageServerLocalNotDirError(self._path)
Line 468: fileSD.validateDirAccess(self._path)
Line 469: return True
Line 470:
--
To view, visit http://gerrit.ovirt.org/13724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9310e3895e30fa5b2ae9a092aa4c1fef508c8e96
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Better Saggi <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
