Dan Kenigsberg has submitted this change and it was merged. Change subject: Change of ConfigWriter._createConfFile parameters ......................................................................
Change of ConfigWriter._createConfFile parameters ifcfg.ConfigWriter._createConfFile now accepts _ipConfig object instead of number of arguments. It helps to reduce number of arguments passed Change-Id: Iae5ec15048ed52170371dda1d0fa9b90d51838e3 Signed-off-by: Petr Sebek <[email protected]> Reviewed-on: http://gerrit.ovirt.org/18331 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/netconf/ifcfg.py M vdsm/netmodels.py 2 files changed, 39 insertions(+), 46 deletions(-) Approvals: Petr Šebek: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae5ec15048ed52170371dda1d0fa9b90d51838e3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Petr Šebek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
