Dan Kenigsberg has posted comments on this change. Change subject: Report bond speed as function of slaved nics speed and bond mode ......................................................................
Patch Set 3: Code-Review-1 (1 comment) .................................................... File lib/vdsm/netinfo.py Line 301: return s Line 302: elif dev in bondings(): Line 303: bondopts = bondOpts(dev, keys=['slaves', 'active_slave', 'mode']) Line 304: if bondopts['slaves']: Line 305: _FAILOVER_MODES = frozenset(['1', '3']) speed() is called very often. Please define these constants are defined at the module level. Sorry for not saying that explicitly earlier. Line 306: _LOADBALANCE_MODES = frozenset(['0', '2', '4', '5', '6']) Line 307: if bondopts['mode'][1] in _FAILOVER_MODES: Line 308: s = speed(bondopts['active_slave'][0]) Line 309: elif bondopts['mode'][1] in _LOADBALANCE_MODES: -- To view, visit http://gerrit.ovirt.org/19297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide077846e49ac5e4d759a85ff9d5c6cec653aa18 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
