Greg Padgett has uploaded a new change for review.

Change subject: vdsm: prevent stale vm stats if qemu process exits
......................................................................

vdsm: prevent stale vm stats if qemu process exits

If the qemu process stops, releaseVm() is called, but the deleteVm()
method isn't.  This leaves stale metadata about the vm, causing
subsequent vm startup attempts to fail with "Virtual machine already
exists".

Fix this by adding the missing call to deleteVm().

Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f
Bug-Url: https://bugzilla.redhat.com/1010980
Signed-off-by: Greg Padgett <gpadg...@redhat.com>
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/19470/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index f356c08..c008b86 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2165,6 +2165,8 @@
                 self.setDownStatus(NORMAL, 'User shut down')
             else:
                 self.setDownStatus(ERROR, "Lost connection with qemu process")
+        # Clean VM from the system
+        self.deleteVm()
 
     def _loadCorrectedTimeout(self, base, doubler=20, load=None):
         """


-- 
To view, visit http://gerrit.ovirt.org/19470
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to