Saggi Mizrahi has posted comments on this change. Change subject: jsonrpc: Add SSL support to asyncore transport ......................................................................
Patch Set 6: (2 comments) .................................................... File lib/yajsonrpc/betterAsyncore.py Line 78: Line 79: return result Line 80: Line 81: def _loadCAs(self): Line 82: context = self.context I don't understand, what param? Do you mean variable? doing x = self.x just makes things a bit faster and helps make sure you don't do stupid typos since pyflakes can check local variables and not instance variables Line 83: Line 84: if self.ca_cert: Line 85: context.load_verify_locations(self.ca_cert) Line 86: context.set_verify( .................................................... File lib/yajsonrpc/protonReactor.py Line 63: self._connected = False Line 64: Line 65: def setTimeout(self, timeout): Line 66: # TODO Line 67: pass Log what? That we still have not implemented timeout? Line 68: Line 69: def closed(self): Line 70: return (self.connector is None or Line 71: proton.pn_connector_closed(self.connector)) -- To view, visit http://gerrit.ovirt.org/15426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad305e26d7d62fd967c71e5ac4dbd8157639a36d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
