Dan Kenigsberg has submitted this change and it was merged. Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets ......................................................................
iscsiadm: Filter out IPv6 addresses when discovering targets This patch is not diminishing any capabilities we have, since we currently don't support ipV6 targets in vdsm. When discovering targets on Netapp storage we get a return value that includes both IPv4 and IPv6 addresses. The only thing I've changed is preventing vdsm from failing discovery because of getting an unexpected response from iscsiadm (our parser is very hardcoded). If we decide to support ipV6 addresses for discovery, login and managing the connection then it needs to be addressed separately. Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Signed-off-by: Yeela Kaplan <ykap...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/19431 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Tested-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/storage/iscsiadm.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Better Saggi <bettersa...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
