mooli tayer has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
......................................................................
Patch Set 12: Verified-1
What I did to test this patch:
a.) Wrote unit tests
b.) Ran cross migration between two hosts running a total of 4 vms. I installed
them from ovirt-stable repo and replaced libvirtconnection.py
I discovered that in patch set 11 and before the whole thing was one big bug:
I wrote wrapper like so:
def wrapper(pingLibvirt=True, *args, **kwargs):
...
ret = f(*args, **kwargs)
and the user of this class called this wrapper for example:
conn.nwfilterLookupByName('someArg')
That would lead to:
pingLibvirt='someArg'
And worse args = []
Shame on me!
After the fix of this patch set the migration still does not work. not sure if
it is related to this patch set or not.
one host becomes non operational (the engine runs getCaps on it and gives the
error: 'Host host_01 running without virtualization hardware acceleration' )
still checking this
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
