Hello Timothy Asir, Saggi Mizrahi, Aravinda VK, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19597
to review the following change.
Change subject: gluster: add node uuid in rebalance and remove-brick status
......................................................................
gluster: add node uuid in rebalance and remove-brick status
This patch adds node uuid as 'id' element to output of rebalance and
remove-brick status. Below verbs are affected
* glusterVolumeRebalanceStatus
* glusterVolumeRemoveBrickStatus
Below is the change in output which doesn't break backward
compatibility
{'summary': {
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
},
'hosts': [{
'name': STRING,
==>> 'id': STRING,
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
}]}
Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea
Signed-off-by: Bala.FA <barum...@redhat.com>
---
M tests/glusterTestData.py
M tests/glusterVolumeRebalanceStatus.xml
M tests/glusterVolumeRemoveBricksStatus.xml
M vdsm/gluster/cli.py
4 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/19597/1
diff --git a/tests/glusterTestData.py b/tests/glusterTestData.py
index 2afd033..fc4d761 100644
--- a/tests/glusterTestData.py
+++ b/tests/glusterTestData.py
@@ -777,6 +777,7 @@
},
'hosts': [{
'name': 'localhost',
+ 'id': '883626f8-4d29-4d02-8c5d-c9f48c5b2445',
'filesScanned': 278,
'filesMoved': 78,
'filesFailed': 0,
diff --git a/tests/glusterVolumeRebalanceStatus.xml
b/tests/glusterVolumeRebalanceStatus.xml
index 42968c5..337075a 100644
--- a/tests/glusterVolumeRebalanceStatus.xml
+++ b/tests/glusterVolumeRebalanceStatus.xml
@@ -9,6 +9,7 @@
<nodeCount>1</nodeCount>
<node>
<nodeName>localhost</nodeName>
+ <id>883626f8-4d29-4d02-8c5d-c9f48c5b2445</id>
<files>78</files>
<size>79872</size>
<lookups>278</lookups>
diff --git a/tests/glusterVolumeRemoveBricksStatus.xml
b/tests/glusterVolumeRemoveBricksStatus.xml
index 26bb97c..5712d19 100644
--- a/tests/glusterVolumeRemoveBricksStatus.xml
+++ b/tests/glusterVolumeRemoveBricksStatus.xml
@@ -7,6 +7,7 @@
<nodeCount>1</nodeCount>
<node>
<nodeName>localhost</nodeName>
+ <id>883626f8-4d29-4d02-8c5d-c9f48c5b2445</id>
<files>78</files>
<size>79872</size>
<lookups>278</lookups>
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 62b5f13..6d7f389 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -620,6 +620,7 @@
for el in tree.findall('node'):
status['hosts'].append({'name': el.find('nodeName').text,
+ 'id': el.find('id').text,
'filesScanned': int(el.find('lookups').text),
'filesMoved': int(el.find('files').text),
'filesFailed': int(el.find('failures').text),
--
To view, visit http://gerrit.ovirt.org/19597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
