Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism ......................................................................
Patch Set 8: @Saggi: Even *if* the Upgrade class isn't reusable, there's an advantage to keeping it separate from UnifiedPersistence which is separation of concerns. The UnifiedPersistence class already has a well defined role - It'd be bad practice to squash the Upgrade class into it as well (Thus giving UnifiedPersistence a 2nd role). If I understand you correctly, you're in favor of remodeling Upgrade so that it is not inherited but composed, even though it is clearly a 'is-a' relationship and not a 'has-a' relationship. I can live with that because the inheritance in this case is a means to an end and not the point. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
