Ayal Baron has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/hsm.py
Line 2261: found = isoDom.getFileList(pattern='*.' + extension,
Line 2262: caseSensitive=False)
Line 2263:
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
why are you filtering out the files with wrong permissions from the dict?
We now have the opportunity to return these together with this information so
that user (engine) would be able to know why a file is not usable...
Line 2266: if value['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'fileStats': filtered}
Line 2269:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
