Dan Kenigsberg has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock ......................................................................
Patch Set 2: (1 comment) .................................................... File vdsm/storage/hsm.py Line 1505: Line 1506: force parameter is deprecated and not evaluated. Line 1507: """ Line 1508: # vars.task.setDefaultException(se.ChangeMeError("%s" % args)) Line 1509: pool = self.getPool(spUUID) # Validates pool connection. WHY? we actually know the answer to the WHY question: it's to make sure we are SPM. Line 1510: dom = sdCache.produce(sdUUID=sdUUID) Line 1511: Line 1512: vars.task.getExclusiveLock(STORAGE, imgUUID) Line 1513: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches