Ayal Baron has posted comments on this change. Change subject: image: Remove redundant activate and deactivate of the same volume ......................................................................
Patch Set 1: Code-Review-1 (2 comments) .................................................... File vdsm/storage/image.py Line 918: tmpVol.prepare(rw=True, justme=True, setrw=True) Line 919: Line 920: # We should prepare/teardown volume for every single rebase. Line 921: # The reason is recheckIfLeaf at the end of the rebase, that change Line 922: # volume permissions to RO for internal volumes. Please read this comment Line 923: srcVol.prepare(rw=True, chainrw=True, setrw=True) Line 924: try: Line 925: # Step 2: Rebase successor on top of tmpVol Line 926: # qemu-img rebase -b tmpBackingFile -F backingFormat -f srcFormat Line 926: # qemu-img rebase -b tmpBackingFile -F backingFormat -f srcFormat Line 927: # src Line 928: backingVolPath = os.path.join('..', srcVolParams['imgUUID'], Line 929: newUUID) Line 930: srcVol.rebase(newUUID, backingVolPath, volParams['volFormat'], Since unsafe rebase doesn't require access to the parent, you can probably replace the second prepare with: srcVol.prepare(rw=True, justme=True, setrw=True). Line 931: unsafe=False, rollback=True) Line 932: Line 933: # Step 3: Remove pointer to backing file from the successor by Line 934: # 'unsafed' rebase qemu-img rebase -u -b "" -F -- To view, visit http://gerrit.ovirt.org/19854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d615fd8e9b199cef1340360c7f68b19919b0caa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches