Alon Bar-Lev has posted comments on this change.
Change subject: Moving coredump configuration to common script
......................................................................
Patch Set 1:
(4 comments)
....................................................
File init/sysvinit/vdsmd.init.in
Line 130
Line 131
Line 132
Line 133
Line 134
add: DAEMON_COREFILE_LIMIT=unlimited NICELVEL...
....................................................
File init/vdsmd_init_common.sh.in
Line 21: VDSM_TOOL="@BINDIR@/vdsm-tool"
Line 22: prog=vdsm
Line 23: CONF_FILE="@CONFDIR@/vdsm.conf"
Line 24: GETCONFITEM="@VDSMDIR@/get-conf-item"
Line 25: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump"
no need constant
Line 26: CORE_PATTERN="/proc/sys/kernel/core_pattern"
Line 27:
Line 28: is_coredump="$("${GETCONFITEM}" "${CONF_FILE}" vars core_dump_enable
false | tr A-Z a-z)"
Line 29: [ "${is_coredump}" != "true" ] && is_coredump=false
Line 22: prog=vdsm
Line 23: CONF_FILE="@CONFDIR@/vdsm.conf"
Line 24: GETCONFITEM="@VDSMDIR@/get-conf-item"
Line 25: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump"
Line 26: CORE_PATTERN="/proc/sys/kernel/core_pattern"
no need constant
Line 27:
Line 28: is_coredump="$("${GETCONFITEM}" "${CONF_FILE}" vars core_dump_enable
false | tr A-Z a-z)"
Line 29: [ "${is_coredump}" != "true" ] && is_coredump=false
Line 30:
Line 24: GETCONFITEM="@VDSMDIR@/get-conf-item"
Line 25: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump"
Line 26: CORE_PATTERN="/proc/sys/kernel/core_pattern"
Line 27:
Line 28: is_coredump="$("${GETCONFITEM}" "${CONF_FILE}" vars core_dump_enable
false | tr A-Z a-z)"
please convert to function...
but really, you do not need it... just put this bellow.
task_configure_coredump() {
if "${GETCONFITEM}" "${CONF_FILE}" vars core_dump_enable false | tr A-Z
a-z | grep -q true; then
echo "/var/log/core/core.%p.%t.dump" > /proc/sys/kernel/core_pattern
fi
}
Line 29: [ "${is_coredump}" != "true" ] && is_coredump=false
Line 30:
Line 31: #### pre-start tasks ####
Line 32: task_configure_coredump() {
--
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
