Alon Bar-Lev has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
......................................................................
Patch Set 6:
(2 comments)
....................................................
File init/vdsmd_init_common.sh.in
Line 219: "
Line 220: ;;
Line 221: --post-stop)
Line 222: run_tasks " \
Line 223: run_final_hooks \
indent missing
Line 224: "
Line 225: ;;
Line 226: --help|*)
Line 227: usage
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 199: #
Line 200: if [ "${force_reconfigure}" != "--force" ] && \
Line 201: ! [ -f "${FORCE_RECONFIGURE}" ] && \
Line 202: is_already_configured "${lconf}" "${qconf}" "${ldconf}"
"${qlconf}"; then
Line 203: echo "Not forcing reconfigure"
wrong indent?
Line 204: return 0
Line 205: fi
Line 206:
Line 207: # Remove a previous configuration (if present)
--
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
