Saggi Mizrahi has posted comments on this change.
Change subject: Rescan FC when rescanning for new multipath devices
......................................................................
Patch Set 5:
(2 comments)
....................................................
File lib/vdsm/utils.py
Line 798: if append:
Line 799: cmd.append("--append")
Line 800:
Line 801: cmd.extend(outputFiles)
Line 802: proc = execCmd(cmd, sync=False)
This is *the* wrapper of tee. So here it's fine.
As to splitting up execCmd(), this will happen in the near future.
Line 803: proc.stdin.write(data)
Line 804:
Line 805: def parser(rc, out, err):
Line 806: if rc != 0:
....................................................
File vdsm/storage/multipath.py
Line 107: Should only be called from hsm._rescanDevices()
Line 108: """
Line 109:
Line 110: # First ask fc and iSCSI to rescan all of their sessions
Line 111: fc.rescan()
No, it does the iscsi rescan not fc lip reset.
It makes sense when you realize that iscsiadm is the iscsi administration tool
and not the fc administration tool.
Line 112: iscsi.rescan()
Line 113:
Line 114: # Now let multipath daemon pick up new devices
Line 115:
--
To view, visit http://gerrit.ovirt.org/19539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
