Eduardo has posted comments on this change. Change subject: Fill volume children info. ......................................................................
Patch Set 1: (1 comment) .................................................... File vdsm/storage/volume.py Line 900: info['truesize'] = "0" Line 901: info['mtime'] = "0" Line 902: info['status'] = "INVALID" Line 903: Line 904: # Both engine and dumpStorageTable don't use this option so 1) It is still true that actually they are not consumers of this field. 2) This is a different patch because is breaking BC if someone relies on a false empty list. The former one no affects BC. Line 905: # only keeping it to not break existing scripts that look for the key Line 906: info['children'] = list(self.getChildren()) Line 907: Line 908: # If image was set to illegal, mark the status same -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
