Dan Kenigsberg has submitted this change and it was merged. Change subject: oop: improve safety for truncateFile ......................................................................
oop: improve safety for truncateFile In order to make truncateFile safer and to avoid any confusion on its behavior: * a new comment has been added mentioning O_TRUNC and "w" to avoid any future mistake in this area * a new test has been added to check the expected outcomes * the "w" mode has been removed from truncateFile (used in os.fdopen) to prevent any future reconversion to open(path, "w") * the risk of a file descriptor leak (for a failing os.fdopen call) has been removed using the relevant posix calls Change-Id: Ib71b53498c7bc4ea7a1ab725feb18bc5929f8c85 Signed-off-by: Federico Simoncelli <fsimo...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/20046 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Sergey Gotliv <sgot...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/remoteFileHandlerTests.py M vdsm/storage/remoteFileHandler.py 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Verified Sergey Gotliv: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib71b53498c7bc4ea7a1ab725feb18bc5929f8c85 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
