Alon Bar-Lev has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
......................................................................
Patch Set 9:
(1 comment)
....................................................
File lib/vdsm/tool/configurator.py
Line 98:
Line 99: try:
Line 100: with open(sanlock_pid_file, "r") as f:
Line 101: sanlock_pid = f.readline().strip()
Line 102: sanlock_status = open(proc_status_path % sanlock_pid, "r")
yes, in procedural like mean... which is invalid.
either use:
with open() as f:
move all logic here
so it will be closed when return/exit/exception whatever automatically.
or use try and finally.
Line 103: except IOError as e:
Line 104: if e.errno == os.errno.ENOENT:
Line 105: sys.stdout.write("sanlock service is not running\n")
Line 106: return retval # service is not running, returning
--
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
