Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing libvirt_configure from pre-start and ask for manual run ......................................................................
Removing libvirt_configure from pre-start and ask for manual run Before starting vdsmd we need to add vdsm configuration to libvirtd.conf. This part is performed by vdsm-tool libvirt_configure verb. Currently we call it as part of init script pre-start function, but doing that must follow restart of depended services as libvirtd. We don't want to restart services as part of vdsmd init script, so this patch detach the auto reconfigure and report to user to perform it manually if attempt to start vdsmd without having libvirtd.conf configured. Performing start\stop actions on external services during service start is invalid and can lead to bugs in different service managers. Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013371 Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/19737 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M init/vdsmd_init_common.sh.in M lib/vdsm/tool/libvirt_configure.py M lib/vdsm/tool/libvirt_configure.sh.in 3 files changed, 70 insertions(+), 31 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
