Federico Simoncelli has posted comments on this change. Change subject: Make getRepoStats() a hsm method. ......................................................................
Patch Set 8: Verified-1 Code-Review-1 (1 comment) 'isoprefix' is not returned and you can't run VMs with cdroms. .................................................... File vdsm/storage/hsm.py Line 2544: poolInfo = pool.getInfo() Line 2545: doms = pool.getDomains() Line 2546: domInfo = self._getDomsStats(pool.domainMonitor, doms) Line 2547: for sdUUID in doms.iterkeys(): Line 2548: if 'isoprefix' in domInfo[sdUUID] and domInfo[sdUUID]['isoprefix']: 'isoprefix' is not returned by _getDomsStats, it's returned by _getRepoStats. The end result is that 'isoprefix' is not reported and you can't run VMs with cdroms. Line 2549: poolInfo['isoprefix'] = domInfo[sdUUID]['isoprefix'] Line 2550: Line 2551: return dict(info=poolInfo, dominfo=domInfo) Line 2552: -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Elad Ben Aharon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
