Federico Simoncelli has posted comments on this change.

Change subject: lvm: refresh on mda permission mismatch
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/lvm.py
Line 1299:         changelv(vg, lv, ("--permission", permission))
Line 1300:     except se.StorageException:
Line 1301:         l = getLV(vg, lv)
Line 1302:         if l.attr.permission == 'R':
Line 1303:             refreshLV(vg, lv)
I am still not convinced that this is the appropriate fix. I'd prefer to fix 
this in lvm.
Line 1304:             l = getLV(vg, lv)
Line 1305:         if l.writeable == rw:
Line 1306:             # Ignore the error since lv is now rw, hoping that the 
error was
Line 1307:             # because lv was already rw, see BZ#654691. We may hide 
here


-- 
To view, visit http://gerrit.ovirt.org/20121
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to