Saggi Mizrahi has posted comments on this change. Change subject: remoteFileHandler: config logging in spawned process ......................................................................
Patch Set 7: As my comment on the related BZ I did http://gerrit.ovirt.org/14626 which covers errors in remoteFileHandler.py itslef. Since all operations being run are small and throw exceptions so being able to write to the log doesn't seem to be an issue to me. I also don't trust python's logging system and it will probably add more complexity than needed to the handlers making them take more memory which is problematic as it is. I suggest this bug be closed with WONTFIX -- To view, visit http://gerrit.ovirt.org/9182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Better Saggi <bettersa...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
