Dan Kenigsberg has posted comments on this change.
Change subject: lvm: fix pv_count and pv_names check
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/lvm.py
Line 410: vgsFields[uuid][pvNameIdx].append(pv_name)
Line 411: for fields in vgsFields.itervalues():
Line 412: vg = makeVG(*fields)
Line 413: if int(vg.pv_count) != len(vg.pv_name):
Line 414: log.error("vg %s has pv_count %s but pv_names %s",
This case must never ever happen. It means that we've failed to parse the
output of lvm or a nasty lvm bug.
Line 415: vg.name, vg.pv_count, vg.pv_name)
Line 416: self._vgs[vg.name] = vg
Line 417: updatedVGs[vg.name] = vg
Line 418: # If we updated all the VGs drop stale flag
--
To view, visit http://gerrit.ovirt.org/20196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a3a2e7c7e5ddc4949eb690c1e4613284db9eafc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
