Antoni Segura Puimedon has posted comments on this change. Change subject: it fixes a bug in the hook validation decorator, that left tests scripts installed into the system. Now they're properly removed right after the tests ......................................................................
Patch Set 1: Code-Review-1 (1 comment) For visibility .................................................... File tests/hookValidation.py Line 79: shutil.rmtree(hook_path) Line 80: Line 81: try: Line 82: os.unlink(cookie_file) Line 83: except OSError: It might be better to only pass when the OSError instance errno is ENOENT. Line 84: pass Line 85: Line 86: if not functional: Line 87: constants.P_VDSM_HOOKS = old_vdsm_hooks -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
