Dan Kenigsberg has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ......................................................................
Patch Set 5: Code-Review-1 (1 comment) oops, I failed to notice this little issue. .................................................... File tests/hookValidation.py Line 80: os.unlink(hook_path + '/' + hook_name) Line 81: else: Line 82: shutil.rmtree(hook_path) Line 83: Line 84: try: that's exactly vdsm.utils.rmFile(cookie_file). Line 85: os.unlink(cookie_file) Line 86: except OSError as unlink_error: Line 87: if unlink_error.errno == os.errno.ENOENT: Line 88: pass -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
