Federico Simoncelli has posted comments on this change.

Change subject: remove symlink when connect local storage failed
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/storageServer.py
Line 418:         if self.checkLink():
Line 419:             return
Line 420:         try:
Line 421:             lnPath = self._getLocalPath()
Line 422:             os.symlink(self._path, lnPath)
I suppose the "try:" should go here.
Line 423:             os.chmod(lnPath, 0775)
Line 424:         except OSError:
Line 425:             os.unlink(lnPath)
Line 426:             raise


-- 
To view, visit http://gerrit.ovirt.org/6140
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44605fb6c6e2512a6aa1acefb3d1d7e09a67aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Better Saggi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to