Nir Soffer has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
....................................................
File vdsm/vm.py
Line 518:
Line 519: for drive, capacity, alloc, physical in extend:
Line 520: self._log.info('%s/%s apparent: %s capacity: %s, alloc:
%s, '
Line 521: 'physical: %s', drive.domainID,
drive.volumeID,
Line 522: drive.apparentsize, capacity, alloc,
physical)
According to Dan comment few version ago, all log lines contains volume
information - check if we don't duplicating volume info in this message.
Line 523: self._vm.extendDriveVolume(drive)
Line 524:
Line 525: def _updateVolumes(self):
Line 526: if not self._vm.isDisksStatsCollectionEnabled():
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
