Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
......................................................................
Patch Set 1:
(2 comments)
....................................................
File lib/vdsm/tool/vdsm-id.py
Line 18: #
Line 19:
Line 20:
Line 21: import sys
Line 22: import argparse
if you're into reordering, alphabetizing would be nice.
Line 23:
Line 24:
Line 25: from vdsm.utils import getHostUUID
Line 26: from vdsm.tool import expose
....................................................
File lib/vdsm/utils.py
Line 631: f.write("%s\n", hostid)
Line 632: if isOvirtNode():
Line 633: from ovirtnode import ovirtfunctions
Line 634:
ovirtfunctions.ovirt_store_config(constants.P_VDSM_NODE_ID)
Line 635: __hostUUID = hostid
why not use __hostUUID to begin with?
Line 636: else:
Line 637: logging.warning('Could not find host UUID.')
Line 638:
Line 639: if legacy:
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
