Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id ......................................................................
Patch Set 6: (1 comment) .................................................... File lib/vdsm/utils.py Line 624: Line 625: if p.returncode == 0 and 'Not' not in out: Line 626: #Avoid error string - 'Not Settable' or 'Not Present' Line 627: __hostUUID = out.strip() Line 628: elif force: :/ What can I say against that.. if there is no way to get better uuid for a server and we must use uuid package so let it be. for now. Although I'm quite convinced that we can find better uuid to use based on the hardware. Don't know how urgent this workaround is, but I would prefer to see hardware based solution.. Line 629: hostid = str(uuid.uuid4()) Line 630: with open(constants.P_VDSM_NODE_ID, 'w') as f: Line 631: f.write("%s\n", hostid) Line 632: ovirtNodePersist([constants.P_VDSM_NODE_ID]) -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches