Allon Mureinik has posted comments on this change. Change subject: lvm: Prevent auto-actviation of logical volumes ......................................................................
Patch Set 3: (3 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-11-03 16:55:45 +0200 Line 4: Commit: Nir Soffer <[email protected]> Line 5: CommitDate: 2013-11-03 22:26:36 +0200 Line 6: Line 7: lvm: Prevent auto-actviation of logical volumes s/actviation/activation/ Line 8: Line 9: When using FC storage, physical volumes are connected during boot, and Line 10: vdsm logical volumes are auto-activated by /etc/rc.sysinit and/or Line 11: /etc/init.d/netfs. This is abnormal situation that vdsm cannot handle, Line 16: lvm 2.02.100. Line 17: Line 18: To make this change easy, lvm.changelv() was modified to accept variable Line 19: argument tuples, instead of multiple non-related types. This also Line 20: simplify the only caller that use multiple arguments. Eduardo - are you referring to this paragraph in the commit message or the change itself? If it's the latter, I tend to agree - IMHO, this should be done in a separate patch. Line 21: Line 22: Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0 Line 23: Bug-Url: https://bugzilla.redhat.com/1009812 .................................................... File vdsm.spec.in Line 187: Requires: sanlock >= 2.4-2, sanlock-python Line 188: Requires: policycoreutils-python Line 189: Requires: sed >= 4.2.1-10 Line 190: Requires: ed Line 191: Requires: lvm2 >= 2.02.100 shouldn't this be a new fedora **19** dependency? Line 192: Line 193: %if 0%{?fedora} >= 18 Line 194: %if 0%{?fedora} >= 19 Line 195: Requires: selinux-policy-targeted >= 3.12.1-71 -- To view, visit http://gerrit.ovirt.org/20832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
