Dan Kenigsberg has posted comments on this change. Change subject: utils: add ovirt-node persistence functions ......................................................................
Patch Set 2: Code-Review+2 (1 comment) .................................................... File lib/vdsm/utils.py Line 900: if isOvirtNode(): Line 901: from ovirtnode import ovirtfunctions Line 902: for f in files: Line 903: if ovirtfunctions.is_persisted(f): Line 904: ovirtfunctions.remove_config([f]) I have no smart suggestions. I feel awkward with the asymmetry between the persist and in persist function. I do not think it matters that much, though. -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
