Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
......................................................................
Patch Set 27:
(2 comments)
....................................................
File lib/vdsm/tool/configurator.py
Line 271: 'If non is specified, operation will run for '
Line 272: 'all related modules.'
Line 273: ),
Line 274: )
Line 275: if action == "configure":
its brilliant :)
Line 276: parser.add_argument(
Line 277: '--force',
Line 278: dest='force',
Line 279: default=False,
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 103: # so continue to use system default init mechanism
Line 104: return 0
Line 105: fi
Line 106:
Line 107: "@CHKCONFIG_PATH@" libvirtd off
ok ok dan .. sorry, most of the time I don't do such things , but alonbl gave
the arrangement spirit and I couldn't hold this motion inside me to delete
those lines. it is not related, only the stop part. I'll get those back, you're
totaly right
Line 108:
Line 109: if ! diff -q "${packaged}" "${target}" >/dev/null 2>&1; then
Line 110: /bin/cp -p "${packaged}" "${target}" || return 1
Line 111: /sbin/initctl reload-configuration
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
