Yaniv Bronhaim has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
......................................................................
Patch Set 10:
(2 comments)
....................................................
File vdsm/caps.py
Line 71: def __init__(self, cpuinfo='/proc/cpuinfo'):
Line 72: """Parse /proc/cpuinfo"""
Line 73: self._info = {}
Line 74: p = {}
Line 75: self.arch = platform.machine()
in private use. please change to _arch
Line 76:
Line 77: for line in file(cpuinfo):
Line 78: if line.strip() == '':
Line 79: p = {}
Line 179: arch = 'x86'
Line 180:
Line 181: for a in cpu_map.getElementsByTagName('arch'):
Line 182: if a.getAttribute('name') == arch:
Line 183: architectureElement = a
can be an attribute error here? you'll miss an element without logging it ..
same for above ^
Line 184:
Line 185: allModels = dict()
Line 186:
Line 187: for m in architectureElement.childNodes:
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
