Allon Mureinik has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices ......................................................................
Patch Set 1: (4 comments) .................................................... Commit Message Line 5: CommitDate: 2013-11-06 02:59:15 +0200 Line 6: Line 7: hsm: Rescan multipath if device is missing when scanning devices Line 8: Line 9: commit 15c7f74365cb5 introduced a regression where multipath rescan is IMHO an explanation of the regression is appropriate here. It's not obvious from reading the code Line 10: never performed if a device is found missing when scanning devices. This Line 11: can cause a host to become non-operational when extending a vg. Line 12: Line 13: This patch fix the regression and adds the missing unittests, hopefully Line 9: commit 15c7f74365cb5 introduced a regression where multipath rescan is Line 10: never performed if a device is found missing when scanning devices. This Line 11: can cause a host to become non-operational when extending a vg. Line 12: Line 13: This patch fix the regression and adds the missing unittests, hopefully s/fix/fixes/ Line 14: preventing the next regression in this hard to verify code. Line 15: Line 16: Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee .................................................... File tests/hsmTests.py Line 28: Line 29: class StatelessHsm(hsm.HSM): Line 30: """ Line 31: HSM has too many dependencies to create an object for testing. This Line 32: subclass has no dependencies and is goog enough for testing methods that do s/goog/good/ Line 33: not use object state. Line 34: """ Line 35: def __init__(self): Line 36: pass Line 47: Line 48: class FakeMultipath(object): Line 49: Line 50: def __init__(self, pathes=()): Line 51: self.log = '' I get what this is doing, but log is a really confusing name. Can we come up with something more obvious? Line 52: self.pathes = set(pathes) Line 53: Line 54: def rescan(self): Line 55: self.log += 'rescan;' -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
