Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
......................................................................
Patch Set 30:
(2 comments)
....................................................
File init/sysvinit/vdsmd.init.in
Line 208: reconfigure "$@"
Line 209: RETVAL=$?
Line 210: ;;
Line 211: *)
Line 212: echo "Usage: $0
{start|stop|status|restart|force-reload|try-restart|condrestart|reconfigure
[force]}"
this is not supported now, so reconfigure should not be exposed, it is backward
compatibility internal usage now.
Line 213: RETVAL=2
Line 214: esac
Line 215:
....................................................
File vdsm.spec.in
Line 732: %{_bindir}/vdsm-tool service-stop supervdsmd >/dev/null 2>&1
Line 733: supervdsmd_start_required='yes'
Line 734: fi
Line 735:
Line 736: %{_bindir}/vdsm-tool configure --force >/dev/null 2>&1
this will not show errors if exist... how can we solve issues?
Line 737:
Line 738: if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 739: %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1
Line 740: fi
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
