Dan Kenigsberg has submitted this change and it was merged. Change subject: iscsi: Iscsi rescan cleanup ......................................................................
iscsi: Iscsi rescan cleanup * Remove forceIscsiScan(): iscsiadm already does that when refreshing sessions * Cleanup iscsi.rescan(): Replace complex logic with a simpler implementation since new iscsiadm takes care of all of this itself * Make iscsi.rescan() more testable * Test confusing timeout semantics of iscsi.rescan() Bug-Url: https://bugzilla.redhat.com/964595 Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Signed-off-by: Saggi Mizrahi <smizr...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/19256 Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/Makefile.am A tests/iscsiTests.py M vdsm.spec.in M vdsm/storage/iscsi.py M vdsm/storage/iscsiadm.py M vdsm/storage/multipath.py M vdsm/supervdsmServer 7 files changed, 111 insertions(+), 62 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Saggi Mizrahi: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
