Dan Kenigsberg has posted comments on this change.
Change subject: Remove onboot, delay from setupNetworks API
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
Commit Message
Line 12:
Line 13: setupNetworks({'nonVM': {'bridged': False, 'nic': 'dummy0',
Line 14: 'onboot': 'no'}}, {}, {})
Line 15:
Line 16: Will write 'ONBOOT=no' to ifcfg-dummy0, both before and after
Is there any reason we'd like to maintain this? ONBOOT is an ifcfg-specific
argument, and we should have it set invariably to "yes". DELAY is settable by
the "forward_delay" option. Both DELAY and forward_delay should go iff Engine
does not (and has never) used that option (using a non-zero DELAY hampers
migration of VMs).
Line 17: this patch. The patch just removes all explicit references
Line 18: to onboot and delay in the code and API documentation.
Line 19:
Line 20: Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2
--
To view, visit http://gerrit.ovirt.org/20967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
