Dan Kenigsberg has posted comments on this change.
Change subject: gluster: performs peer detach using host UUID if provided
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/gluster/api.py
Line 211: def hostAdd(self, hostName, options=None):
Line 212: self.svdsmProxy.glusterPeerProbe(hostName)
Line 213:
Line 214: @exportAsVerb
Line 215: def hostRemove(self, hostName, force=False, options={}):
please avoid mutable arguments like {}. They a function execution to affect a
following execution.
Line 216: host = None
Line 217: hostUuid = options.get('hostUuid')
Line 218:
Line 219: # get hostname of given host uuid
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
